JENKINS-72224 Prevent deadlock when onConfigurationChange()
is called frequently
#1391
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-72224 Prevent deadlock during frequent calls to
onConfigurationChange()
Unexpected deadlock added on
I was missing that the
onConfigurationChange
was also calling therefreshModel
. It caused deadlock on busy instance with many nodes.This PR restores the original code from
refreshModel
that just probe for label.The
saveNodeLabel
it's now just called on thepreOnline
phase just after labels are collected.The use case is really for ephemeral agent that connect frequently and to ensure those labels sees the new node.
I think there is a almost no chance that platform labels changes when a node is modified or when an other node connect. According to https://javadoc.jenkins.io/hudson/slaves/ComputerListener.html#onConfigurationChange() it's called every time a node is added or removed
Checklist
Types of changes
What types of changes does your code introduce?